Added only_links_like Feature #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I second this feature! I basically implemented the same thing locally on my machine so I could get it to work. I guess I should've checked here first. Anemone is awesome, btw! |
| @@ -292,10 +302,18 @@ def skip_query_string?(link) | |||
|
|
|||
| # | |||
| # Returns +true+ if *link* should not be visited because | |||
| # its URL matches a skip_link pattern. | |||
| # its URL matches a skip_link pattern or not matches a only_link pattern. | |||
| # | |||
| def skip_link?(link) | |||
There was a problem hiding this comment.
@only_link_patterns.empty?
? @skip_link_patterns.any? { |pattern| link.path =~ pattern }
: !@only_link_patterns.any? { |pattern| link.path =~ pattern }@hartator would u care to re-submit in the Medusa fork?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks a lot for anemone guys!
I missed a feature that I have implemented, basically the reverse of
skip_links_like, which I have calledonly_links_liketo help the crawler to follow only links which matches specified patterns.Anyway, I wish you great succes with your project!
Best,
Julian