Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Fork's Visibility #297

Open
wants to merge 520 commits into
base: master
Choose a base branch
from

Conversation

dmgolembiowski
Copy link

@chrisknepper it might not be a terrible idea to merge this as a PR simply because it's preserves the legacy of your work and makes it easier for other contributors to find and perpetuate it.

dependabot bot and others added 30 commits October 18, 2020 20:54
…-loader-8.0.6

Bump ts-loader from 8.0.5 to 8.0.6
…pes/webpack-4.41.23

Bump @types/webpack from 4.41.22 to 4.41.23
Restyle Set StartupWMClass in desktop file for linux builds
fix settings accelerator; hide menu when toggled
Google actually made things easier switching to an all canvas based icon system.

Closes #176 As far as I can tell
OrangeDrangon and others added 30 commits April 26, 2022 22:01
* yarn upgrade --latest

* remove unused dependencies

* bump dependencies
…nk (#396)

* disable writing of settings when quitting

* only register on ready listener if we got the single instance lock
* Bump User Agent String to Firefox 108

* Fix User Agent String to look more authentic
Co-authored-by: hloth <[email protected]>
* fixup

* force exports to null to somehow make emoji load
Modified how the user agent is set when sending headers. There were two issues that I was able to identify.

First, the Google sign-in page sends requests to the youtube.com domain sometimes, so the existing replacement effect was not always firing. Adding a url entry for this domain fixes this problem.

Second, Google sometimes doesn't like the hard-coded user agent this project was previously providing. I have no idea why -- this Electron/user agent/Google problem has been ongoing for years. I've solved this problem this time by instead taking the user agent Electron would have passed by itself and stripping out only the Electron-specific component.

I don't know how long this fix will last, since Google seems intent on being opaque about how they determine if a browser is secure or not. Fingers crossed.

Co-authored-by: Doc Islands <[email protected]>
* update node version

* fix name fetching for tray

* use non deprecated way of opening link

* update actions

* update dependencies

* upload actions
* Modifying handleTrayClick to minimize when window is visible.

* Style matching
* Upgrade electron version

Ran `yarn add electron`

* Remove context isolation

I couldn't get the application to run unless I unset contextIsolation.
So here is the application split into preload and node files.

Makes iterop a bit more painful. But everything seems to work, at least
as far as I tested. I think the interop stuff makes error logging a bit
painful, so I may have missed the mark a bit. I can say for certain that
clicking notifications works as expected. The mutation observer stuff
I'm a little less clear on. (But the functions are called when I used
console.log statements).

I completely removed the profileImage stuff, it doesn't appear to be
necessary. Maybe its just Linux, but the notification rendered the
NotificationsOptions.icon that was provided by the google SPA just
fine without all the cache code.

* Fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.