This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Fixes issue #5 problems with DateTime format for Mixpanel #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @StanleyGoldman and @EliSchleifer can you guys give these changes a try. They should work but I have not had time to test them out. Assuming it's all good I can merge this and release to Nuget. |
|
Hey @StanleyGoldman I'd like to merge this in soon. Let me know if you can take a quick look at it. |
|
I'll peer review it later on tonight. |
| propertyBag.Remove("Time"); | ||
| } | ||
| if (_options.SetEventTime && !properties.Keys.Any(x => x.ToLower() == "time")) | ||
| propertyBag["time"] = DateTime.UtcNow.FormatDate(); |
There was a problem hiding this comment.
The old code would rename Time to time whereas the new code doesn't. I suspect that was done because mix panel is case sensitive on that property (but that's just a guess).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.