Add missing aborts and typehints for sdoclient #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also synchronous RPDOs should now be transmitted on sync reception Need to add more tests for this last part
…erg#345) * Fixed incorrect min (LowLImit) and max (HighLimit) values when using signed integer types. * Fixed min/max for non-signed datatypes and added tests * Removed type hints
-adding typehints -adding some missing sdo aborts (timeout, unknown command)
This reverts commit 074be34.
|
reverting the PDO change that has nothing to do with this PR |
|
@samsamfire Sorry for not responding for such a long time. I've tried to grasp your changes here in order to see if there's merit in merging it for the next release. However, it is quite convoluted between actual changes and formatting. Would you mind separating those into several smaller PRs or at least split into independent commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found some missing aborts whilst doing some tests:
in particular, an sdo abort should be sent when a timeout occurs (0x05040000)
an abort should also be sent if the expected command value is not correct (0x05040001).
I also added typehints were possible.
Also, have any of you considered to add a static type checker (mypy,...) and a linting tool ? Could be good in the future