Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add warning block and puts warning in a collapsable detail element #24

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

Remi-Gau
Copy link
Contributor


  • add a test that throws warnings
  • add a jinja black for warnings
  • put warnings into a detail element

@Remi-Gau
Copy link
Contributor Author

Sending snapshots eventhough the workflow seems to upload testing artefacts for quick inspection.

image

image

@Remi-Gau
Copy link
Contributor Author

I know the styling needs more work: let me know what you would prefer and I can try to make it work.

I have started adding more styling things in a the downstream template that I use, but I am not sure it makes sense to put them in this PR.

For my usecase it makes sense to sort warnings by category first and then by file where they occur but maybe other people will want something different.

So let me know what you think would be a good default for the package.

@christiansandberg
Copy link
Owner

christiansandberg commented Jun 27, 2024

I think you need to update the CSS to reflect the extra level so that the badge and text aligns correctly.

If you have other improvements that would also be welcome. There is not much thought behind how the warnings are displayed.

@Remi-Gau
Copy link
Contributor Author

Made some adjustments that should be fine in most use case (I hope)

image

image

@christiansandberg christiansandberg merged commit 5776096 into christiansandberg:master Jun 28, 2024
1 check passed
@Remi-Gau Remi-Gau deleted the warning branch June 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put warnings in a jinja block
2 participants