Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Introduction #9

Merged
merged 2 commits into from
May 31, 2024
Merged

Draft Introduction #9

merged 2 commits into from
May 31, 2024

Conversation

f-allian
Copy link
Collaborator

@christopher-wild Let me know what you think of this too - will be working on semantic versioning today :)

Copy link

github-actions bot commented May 28, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/christopher-wild/FAIR4RS-Packaging/compare/md-outputs..md-outputs-PR-9

The following changes were observed in the rendered markdown documents:

 fig/package.png (new) | Bin 0 -> 259459 bytes
 introduction.md       | 169 ++++++++++++++++++++++++++++++++------------------
 md5sum.txt            |  23 +++----
 3 files changed, 122 insertions(+), 70 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-31 10:50:07 +0000

github-actions bot pushed a commit that referenced this pull request May 28, 2024
@f-allian f-allian linked an issue May 28, 2024 that may be closed by this pull request
Copy link
Owner

@christopher-wild christopher-wild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this episode! I see what you mean about interactivity and I think this would go down well. Just left some comments about some of the files in the example.

```
📦 my_project/
├── 📂 my_package/
│ └── 📄 __init__.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pep420 __init__.py are optional, I don't really use them for example.

Is it worth not mentioning them to avoid questions / confusion about what they are?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopher-wild Agreed that __init.py isn't needed in this example, but there's a big difference between regular packages and namespace packages. Also, backwards compatibility is an important consideration here too.

I'll make a callout to clarify this point as I think it's important to know.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is that difference but I dont think I've ever come across a package that has made use of splitting the package contents among multiple paths with the same namespace. It sounds like a very complicated structure!

- 📦 `my_project/` is the root directory of the project.
- 📂 `my_package/` is the package directory containing the source code.
- 📄 `__init__.py` is an initialisation script (note; this also lets Python know that there are importable modules in this directory).
- 📄 `setup.py` is a script for setting up the package, containing basic metadata. Tools such as `setuptools` and `pip` use this script to configure how the package is built, distributed, and installed.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the example file be a pyproject.toml file as that is the latest standard?

@christopher-wild christopher-wild self-requested a review May 29, 2024 10:25
@christopher-wild christopher-wild marked this pull request as ready for review May 29, 2024 10:25
@f-allian f-allian merged commit 64f4553 into main May 31, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 31, 2024
github-actions bot pushed a commit that referenced this pull request May 31, 2024
Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request May 31, 2024
Auto-generated via {sandpaper}
Source  : e46bb6c
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-31 10:51:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : befd4d3
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-04 01:15:19 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : 8a6899a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-11 01:16:29 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : dbe5e00
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-18 01:16:32 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 64f4553
Branch  : main
Author  : Farhad Allian <[email protected]>
Time    : 2024-05-31 10:50:33 +0000
Message : Merge pull request #9 from christopher-wild/f-allian-branch

Introduction
@f-allian f-allian linked an issue Jul 16, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback: Section 1. Introduction Introduction to FAIR4RS and Software Packaging
2 participants