Skip to content

Commit

Permalink
Update libxml2 to 2.9.4.
Browse files Browse the repository at this point in the history
Add test.xml stanza for Gaea.
Disable garbage collection completely to avoid memory management bugs in libraries.
  • Loading branch information
christopherwharrop-noaa committed Aug 1, 2016
1 parent df994c9 commit aa8efb4
Show file tree
Hide file tree
Showing 12 changed files with 11 additions and 18 deletions.
2 changes: 1 addition & 1 deletion INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ for file in `ls sbin | grep -v '\.sh'`; do
done

# Package versions
LIBXML2_VERSION="2.9.3"
LIBXML2_VERSION="2.9.4"
LIBXML_RUBY_VERSION="2.8.0"
SYSTEMTIMER_VERSION="1.2.3"
SQLITE3_VERSION="autoconf-3120200"
Expand Down
1 change: 0 additions & 1 deletion lib/workflowmgr/cobaltbatchsystem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ def refresh_jobqueue


queued_jobs=nil
GC.start

end # job_queue

Expand Down
2 changes: 0 additions & 2 deletions lib/workflowmgr/moabbatchsystem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ def refresh_jobqueue
} # queued_jobs.find

queued_jobs=nil
GC.start

end

Expand Down Expand Up @@ -319,7 +318,6 @@ def refresh_jobacct
}

recordxml=nil
GC.start

end

Expand Down
2 changes: 0 additions & 2 deletions lib/workflowmgr/moabtorquebatchsystem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ def refresh_jobqueue
} # queued_jobs.find

queued_jobs=nil
GC.start

end

Expand Down Expand Up @@ -280,7 +279,6 @@ def refresh_jobacct
}

recordxml=nil
GC.start

end

Expand Down
1 change: 0 additions & 1 deletion lib/workflowmgr/sgebatchsystem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ def refresh_jobqueue
} # queued_jobs.find

queued_jobs=nil
GC.start

end

Expand Down
1 change: 0 additions & 1 deletion lib/workflowmgr/torquebatchsystem.rb
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ def refresh_jobqueue
} # queued_jobs.find

queued_jobs=nil
GC.start

end # job_queue

Expand Down
2 changes: 0 additions & 2 deletions lib/workflowmgr/utilities.rb
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ def WorkflowMgr.run4(command,timeout=30)
[output,error,exit_status]

ensure
# Make sure we turn garbage collection back on!
GC.enable

end

Expand Down
8 changes: 0 additions & 8 deletions lib/workflowmgr/workflowdoc.rb
Original file line number Diff line number Diff line change
Expand Up @@ -732,10 +732,6 @@ def expand_metataskdeps
@workflowdoc.root.each_element {|ch|
if ch.name == "task"

# Initiate garbage collection to avoid seg faults resulting from LibXML
# memory management issues/bugs
GC.start

# Find the metataskdep nodes
metataskdeps=ch.find('.//metataskdep')

Expand Down Expand Up @@ -795,10 +791,6 @@ def expand_serialdeps
depnode=nil
andnode=nil

# Initiate garbage collection to avoid seg faults resulting from LibXML
# memory management issues/bugs
GC.start

# Add dependencies for each serial metatask that this task is a member of
metatasklist=ch.attributes["metatasks"]
metatasklist.split(",").each_with_index do |m,idx|
Expand Down
3 changes: 3 additions & 0 deletions lib/workflowmgr/workflowengine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ def initialize(options)

begin

# Disable garbage collection
GC.disable

# Turn on full program tracing for verbosity 1000+
if WorkflowMgr::VERBOSE > 999
set_trace_func proc { |event,file,line,id,binding,classname| printf "%10s %s:%-2d %10s %8s\n",event,file,line,id,classname }
Expand Down
Binary file removed tarfiles/libxml2-2.9.3.tar.gz
Binary file not shown.
Binary file added tarfiles/libxml2-2.9.4.tar.gz
Binary file not shown.
7 changes: 7 additions & 0 deletions test/test.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@
<!ENTITY QUEUE "batch">
<!ENTITY SCHED "moabtorque">

<!--
<!ENTITY TEST_HOME "/autofs/mnt/ncrc-svm1_home1/Christopher.W.Harrop/opt/rocoto/master/test">
<!ENTITY DATA_HOME "/lustre/f1/Christopher.W.Harrop">
<!ENTITY PROJECT "esrl_bmcs">
<!ENTITY QUEUE "batch">
<!ENTITY SCHED "moab">
-->
<!--
<!ENTITY TEST_HOME "/home/harrop/rocoto-devel/test">
<!ENTITY DATA_HOME "/lfs1/jetmgmt/harrop/test">
Expand Down

0 comments on commit aa8efb4

Please sign in to comment.