Skip to content

Commit

Permalink
Bug Fix:
Browse files Browse the repository at this point in the history
The matching of metatask contents for automated insertion of dependencies
for "serial" tasks was not bounded by metatask membership.  This caused
metatask sequences for tasks belonging to other metatasks to be matched
and resulted in incorrect dependencies being created.  This has been fixed.
  • Loading branch information
christopherwharrop-noaa committed Sep 3, 2015
1 parent 53dad16 commit e55ff07
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/workflowmgr/workflowdoc.rb
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,8 @@ def expand_serialdeps

# Insert a task dep for each dependent task
tasks.each do |t|
# Reject tasks that aren't a member of metatask m
next if t.attributes["metatasks"].split(",").find_index(m).nil?
taskdepnode=LibXML::XML::Node.new("taskdep")
LibXML::XML::Attr.new( taskdepnode, "task", t.attributes["name"] )
andnode << taskdepnode
Expand Down

0 comments on commit e55ff07

Please sign in to comment.