Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_software_version when patching bridge version #89

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

duvholt
Copy link
Contributor

@duvholt duvholt commented Mar 1, 2025

While investigating why the Hue app kept disconnecting I noticed that the Hue bridge version reported from /clip/v2/resource was different.

Real bridge: 1.69.1969060020

Bifrost: 1.69.0

Context:

    "product_data": {
        "certified": true,
        "manufacturer_name": "Signify Netherlands B.V.",
        "model_id": "BSB002",
        "product_archetype": "bridge_v2",
        "product_name": "Hue Bridge",
        "software_version": "1.69.1969060020"
      },

Changed this to use the proper version seems to fix the disconnect issue!

I'm guessing that get_legacy_apiversion was never meant to be used here?

@chrivers
Copy link
Owner

chrivers commented Mar 2, 2025

Excellent work!

That explains why the entertainment-reversing branch did not have this problem: 84bc49f

Thank you very much for tracking this bug down. I'll get this merged 👍

@chrivers chrivers merged commit 5ca6c3a into chrivers:master Mar 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants