Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Local segment manager memory leak fix #3337

Closed
wants to merge 1 commit into from
Closed

[BUG]: Local segment manager memory leak fix #3337

wants to merge 1 commit into from

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Dec 19, 2024 •
edited
Loading

Description of changes

Closes #3336

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes the memory leak issue by replacing close_persistent_index with close which also unsubscribes the segment from Embeddings Queue
    • Makes the LRUCache thread-safe
    • Adds an evict func to manually remove segments that have been deleted

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

After this fix a prolonged test over 12h+ shows no memory leak:

image

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov Graphite App
Copy link
Contributor Author

tazarov commented Dec 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tazarov tazarov added bug Something isn't working Local Chroma An improvement to Local (single node) Chroma labels Dec 19, 2024
@tazarov tazarov requested review from HammadB and itaismith December 19, 2024 16:09
@tazarov
Copy link
Contributor Author

tazarov commented Dec 19, 2024

TODO: Stack this on top of #3297

@tazarov
Copy link
Contributor Author

tazarov commented Dec 19, 2024

Closing in favor of #3340

@tazarov tazarov closed this Dec 19, 2024
@tazarov tazarov deleted the trayan-12-17-bug_lrucache_memory_leak branch December 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB Awaiting requested review from HammadB

@itaismith itaismith Awaiting requested review from itaismith

Assignees
No one assigned
Labels
bug Something isn't working Local Chroma An improvement to Local (single node) Chroma
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Local Segment Manager memory leak
1 participant
@tazarov