Skip to content

[ENH] Add rust log service memberlist #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

[ENH] Add rust log service memberlist #4415

merged 6 commits into from
May 28, 2025

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented May 1, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds the rust log service to be tracked by a memberlist by sysdb
    • Added the new Memberlist CR, and associated roles
    • Wired up the Sysdb to manage this memberlist
  • New functionality
    • ...

Test plan

I verified the new memberlist is updated, existing ML tests cover the ML
Screenshot 2025-05-22 at 1 19 00 PM

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Collaborator Author

HammadB commented May 1, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented May 1, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

github-actions bot commented May 1, 2025

✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to main.

@HammadB HammadB marked this pull request as ready for review May 22, 2025 20:21
Copy link
Contributor

propel-code-bot bot commented May 22, 2025

Add Rust Log Service Memberlist to Chroma System Database Management

This PR introduces a new Kubernetes Custom Resource (CR) and corresponding RBAC configuration for managing a memberlist specific to the Rust log service within the Chroma cluster. The sysdb service is updated to create and manage the Rust log service memberlist via its configuration, wiring, and CLI flag handling. Supporting changes update the Helm chart version and expand the Tiltfile to ensure deployment orchestration incorporates the new resource.

Key Changes:
• Adds a new Kubernetes MemberList CR for the Rust log service, alongside ClusterRole and ClusterRoleBinding definitions for both sysdb and rust-frontend-service.
• Augments sysdb server configuration and CLI options to accept Rust log service memberlist parameters (name/pod label) and initializes its management in the system database's GRPC server.
• Enhances the sysdb server initialization workflow to properly create, error-check, and start the memberlist manager for the log service.
• Helm chart bumped to v0.1.40; Tiltfile includes the new memberlist resource for dev environments.

Affected Areas:
• Kubernetes Helm templates (distributed-chroma)
• Sysdb server configuration and initialization logic (go/pkg/sysdb/grpc/server.go)
• Sysdb CLI flags (go/cmd/coordinator/cmd.go)
• Tiltfile/dev environment setup

This summary was automatically generated by @propel-code-bot

@HammadB HammadB enabled auto-merge (squash) May 22, 2025 20:29
@HammadB HammadB merged commit adca0c4 into main May 28, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants