[BUG] is_default_schema does not do a space check for defaults or #embedding

[jairad26]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • There is a bug in schema where is_default_schema does not check the space when confirming if the schema is default. This was hidden by our e2e tests, since we used an ef with a default space of cosine. therefore the configuration was cosine and was automatically converted into the schema and tests passed. this PR adds a new test to confirm the basic space setting scenario works
• New functionality
  • ...

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jairad26]

• [TST] add proptest for config & schema reconciliation #5847
• [TST] add schema proptest to python #5823
• [CLN] schema: build default with config ef & default_knn_index, remove #document population in defaults #5775
• [BUG] is_default_schema does not do a space check for defaults or #embedding #5787 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[propel-code-bot]

Fix is_default() to validate space for default & #embedding vector configs

The PR addresses an edge-case where Schema::is_default() incorrectly reported schemas as default when the vector-index space field was explicitly set (e.g., Some(Cosine)) instead of being left None. The logic now explicitly calls the new helper is_space_default() for both the top-level defaults and the #embedding key. Additional Rust unit tests and Python e2e tests cover the updated behaviour to prevent regressions.

Key Changes

• Added is_space_default() helper and integrated it into Schema::is_value_types_default() and Schema::is_embedding_value_types_default() in rust/types/src/collection_schema.rs
• Updated is_default() early-return conditions to include space validation
• New Rust unit tests test_is_schema_default_with_space & test_is_schema_default_with_embedding_function verifying non-default detection when space/embedding_function differ
• Python e2e tests extended (chromadb/test/api/test_schema_e2e.py) to persist and reload collections that specify space, ensuring cross-language correctness

Affected Areas

• Schema::is_default evaluation logic
• Default schema reconciliation pathways that rely on is_default()
• Test suites (Rust + Python)

This summary was automatically generated by @propel-code-bot