Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use github action to generate cdproto #14

Open
wants to merge 3 commits into
base: old
Choose a base branch
from
Open

use github action to generate cdproto #14

wants to merge 3 commits into from

Commits on May 26, 2021

  1. make the call to easyjson more reliable 

    1. remove "easyjson.go" from the white list so that deprecated
  files (if any) won't stay in the repository.
2. generate "easyjson.go" stubs first so that the source codes
  are valid from the perspetive of syntax, which in turn makes
  it possible to run bootstrap.Generator one by one.
3. run bootstrap.Generator one by one to avoid the occasional
 failure. Error messages when it failed (both the source file
 and import path changed from time to time when it failed):
   # github.com/chromedp/cdproto/cachestorage
   cachestorage/easyjson.go:8:3: can't find import: "encoding/json"
   # github.com/chromedp/cdproto/cast
   cast/easyjson.go:6:3: can't find import: "github.com/mailru/easyjson"
    @ZekeLu
    ZekeLu committed May 26, 2021
    Configuration menu
    Copy the full SHA
    bab26ff View commit details
    Browse the repository at this point in the history

  2. configure github action to generate cdproto 

    1. It can be triggered by push and pull request. The purpose is to
check the changes.

2. It can also be triggered manually. In this case, the versions
of chromium and v8 can be specified. If not specified, it defaults
to the latest version. The changes to the cdproto repository will
be committed to the "build-[id]" branch.
    @ZekeLu
    ZekeLu committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a73cd0b View commit details
    Browse the repository at this point in the history

  3. remove .travis.yml

    @ZekeLu
    ZekeLu committed May 26, 2021
    Configuration menu
    Copy the full SHA
    62019eb View commit details
    Browse the repository at this point in the history