[fuchsia] disable MinidumpStringWriter.ConvertInvalidUTF8ToUTF16

re-enable once LUCI supports invalid UTF8 characters in test logs. Bug: fuchsia:DX-487 Bug: chromium:872892 Bug: chromium:889582 Tested: /system/test/crashpad_tests on Fuchsia device Change-Id: I3d6564423fb20554fdc39ffb7bd8e8bf7b1d3d48 Reviewed-on: https://chromium-review.googlesource.com/1251382 Commit-Queue: Scott Graham <[email protected]> Reviewed-by: Scott Graham <[email protected]>
chromium · Sep 28, 2018 · 0ad7e1f · 0ad7e1f
1 parent 7786acf
commit 0ad7e1f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/minidump/BUILD.gn b/minidump/BUILD.gn
@@ -154,6 +154,10 @@ source_set("minidump_test") {
     "minidump_writable_test.cc",
   ]
 
+  configs += [
+    "../build:crashpad_is_in_fuchsia",
+  ]
+
   deps = [
     ":test_support",
     "../snapshot:test_support",

diff --git a/minidump/minidump_string_writer_test.cc b/minidump/minidump_string_writer_test.cc
@@ -100,6 +100,12 @@ TEST(MinidumpStringWriter, MinidumpUTF16StringWriter) {
   }
 }
 
+// Related tracking issues:
+// https://fuchsia.atlassian.net/browse/DX-487
+// https://bugs.chromium.org/p/chromium/issues/detail?id=872892
+// https://bugs.chromium.org/p/chromium/issues/detail?id=889582
+// TODO: Re-enable test once LUCI supports invalid UTF8 characters in test logs.
+#if !defined(CRASHPAD_IS_IN_FUCHSIA)
 TEST(MinidumpStringWriter, ConvertInvalidUTF8ToUTF16) {
   StringFile string_file;
 
@@ -139,6 +145,7 @@ TEST(MinidumpStringWriter, ConvertInvalidUTF8ToUTF16) {
     EXPECT_NE(output_string.find(0xfffd), base::string16::npos);
   }
 }
+#endif  // !defined(CRASHPAD_IS_IN_FUCHSIA)
 
 TEST(MinidumpStringWriter, MinidumpUTF8StringWriter) {
   StringFile string_file;