jernej/update codeowners #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (116 commits) mac: Update the process_types version of dyld_all_image_infos for 10.15 linux: set dumpable for all signal handlers android: insert app_process at start of handler argv linux: make GetHandlerSocket() params optional linux: fix --monitor-self linux: silence logs on client disconnect make PruneCrashReportDatabase return the number of pruned crash reports chromeos: fix typo Check if attachment directories exist before open [POSIX] stop logging on ENOENT update gyp_crashpad_android.py android, chromeos: fix build breakages [fuchsia] fix crashpad_use_boringssl_for_http_transport_socket path linux: Allow configuring unhandled signals cros: Pass a dir for minidumps to crash_reporter [Log minidump] OutputStream interface and zlib implementation Roll crashpad/third_party/mini_chromium/mini_chromium/ 588976752..660b43a77 (2 commits) linux: initialize crash_loop_before_time member linux: Move Cros crash handling to CrosCrashReportExceptionHandler linux, compat: add a memfd_create wrapper ...
* build: add CMake files for crashpad * add explicit submodule for mini_chromium * make cmake builds work on windows * review feedback, add separate getsentry README * better document changes, add update instructions
This change adds a missing `/SUBSYSTEM:WINDOWS` option to the linker command line on Windows for the `crashpad_handler.exe` binary. Without this option (which the regular Crashpad build system [also adds](https://github.com/getsentry/crashpad/blob/getsentry/handler/handler.gyp#L90)) the resulting executable will open an empty console window on startup, which is particularly unsightly for Windows GUI applications integrating `sentry-native` which would otherwise have no console windows.
feat: Merge in latest upstream
meta: update 2023-09-28
…ntext_writer fix: replace DCHECK with LOG in minimdump_context_writer
Windows ARM64 uses a different ASM variant. The assembly is already correct but the CMake setup for the variant was not. This corrects that to enable building crashpad for Windows ARM64. Beyond this change, an update to zlib is required.
build: adjust for Windows ARM64
Meta: update 2023-11-24
`simd_stub.c` was removed from the repository upstream. This updates the CMakeLists.txt so that it is possible to build for Windows ARM64.
The ARM64 build should use the ARM64 branch. The normal spelling for the CMAKE_SYSTEM_PROCESSOR is ARM64 when building with MSVC toolsets. This allows building for Windows ARM64 with MSBuild + CMake.
build: remove obsolete source file
build: adjust process name matching
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXTwhen stack walking (#77)