Refactor s3client ReadFile interface to return a channel. #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the ReadFiles interface method to be ReadFile and return a channel of []string instead
of passing the channel as a reference in the method.
Also, handles the case of dynamic buffer size configured to handle scanning errors for long lines
on files.
Log the error condition when scanning fails due to a shorter buffer to ensure user is aware
on debug mode.
Adds test to cover it.