Skip to content

Commit

Permalink
Fix biopython build (pyodide#4877)
Browse files Browse the repository at this point in the history
biopython thinks that setuptools needs wheel to make a wheel but it doesn't anymore.
Upstream PR: biopython/biopython#4749
  • Loading branch information
hoodmane authored Jun 21, 2024
1 parent c1a1616 commit be5314b
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/biopython/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ package:
top-level:
- Bio
- BioSQL
requirements:
run:
- numpy
source:
sha256: 78e6bfb78de63034037afd35fe77cb6e0a9e5b62706becf78a7d922b16ed83f7
url: https://files.pythonhosted.org/packages/cc/d4/3d8848191a7a37187704c382e6dfda4d6a47d05a14cd64f004c55a3cd5a1/biopython-1.83.tar.gz
patches:
- "patches/0001-Remove-error-message-if-wheel-is-not-installed.patch"
requirements:
run:
- numpy
about:
home: https://biopython.org/
PyPI: https://pypi.org/project/biopython
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
From 434770dc707c5192159249d098e6dbc660fa6556 Mon Sep 17 00:00:00 2001
From: Hood Chatham <[email protected]>
Date: Thu, 20 Jun 2024 12:31:15 -0700
Subject: [PATCH] Remove error message if wheel is not installed

Since pypa/setuptools#4369 was merged, wheel is vendored into setuptools and no
longer needs to be installed for `bdist_wheel` to work.

Upstream PR:
https://github.com/biopython/biopython/pull/4749
---
setup.py | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/setup.py b/setup.py
index 530b413a9..6cfc48de5 100644
--- a/setup.py
+++ b/setup.py
@@ -37,15 +37,6 @@ except ImportError:
"Try running: python -m ensurepip"
)

-if "bdist_wheel" in sys.argv:
- try:
- import wheel # noqa: F401
- except ImportError:
- sys.exit(
- "We need both setuptools AND wheel packages installed "
- "for bdist_wheel to work. Try running: pip install wheel"
- )
-

# Make sure we have the right Python version.
MIN_PY_VER = (3, 9)
--
2.34.1

0 comments on commit be5314b

Please sign in to comment.