Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance allowed additional fields feature #3

Conversation

healerz
Copy link
Contributor

@healerz healerz commented Dec 11, 2017

No description provided.

composer.json Outdated
@@ -10,7 +10,7 @@
}
],
"require": {
"php": "~7.0",
"php": "~7.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep 7.0 compatibility

*/
public function isAllowedAdditionalFields(): bool
public function getAllowedAdditionalFields(): ?array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename a method is a bc

@dominikzogg dominikzogg merged commit 2a1a5ce into chubbyphp:master Dec 11, 2017
@dominikzogg
Copy link
Member

@healerz thank you

@healerz
Copy link
Contributor Author

healerz commented Dec 11, 2017

@dominikzogg 👍

@healerz healerz deleted the feat/enhanceAllowedAdditionalFieldsFeature branch December 11, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants