New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEO-834 | Fill rails code quality checking section #147

Open

Bulatkin wants to merge 4 commits into develop from feature/PEO-834

Bulatkin commented Apr 15, 2020 •

edited

Loading

JIRA ticket: https://garage.atlassian.net/browse/PEO-834

Description

Filled rails code quality checking section

Before submitting the merge request make sure the following are checked

Followed the style guidelines of this project
Performed a self-review of own code
Wrote the tests that prove that fix is effective/that feature works

Notable changes

Added rails_best_practices to outputter quality section
Filled code quality checking section template

rostikkkk2 and others added 4 commits

February 11, 2020 18:31


          Bump ARD to 1.7.1 & fix something

d6e93d4


          Split ARD tasks into separate runners

f9a725b


          Fixed ARD tests after modification

c1a87f9


          Fill rails code quality checking section

d9f32e3

Bulatkin self-assigned this

chubchenko added the HOLD label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HOLD