RC order fix #537
Open
RC order fix #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current rc.d/vm REQUIREs 'NETWORKING' but is also BEFORE pf/ipfw. This is not well formed (as NETWORKING relies on pf/ipfw), but is desired to generate bridges before pf/ipfw are generated. Likewise for iscsi attachments to work, vm needs to be after NETWORKING. Split into vm_net (early / bridge generation) and vm (late / vm start as well as shutdown) phases/rc.d files. This allows non-circular ordering of dependencies. We don't currently have a clean way to stop and restart the 'init' phase, especially in light of potentially needing to reload firewalls rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split startup into two phases (bridges/vms)
The current rc.d/vm REQUIREs 'NETWORKING' but is also BEFORE pf/ipfw. This is not well formed (as NETWORKING relies on pf/ipfw), but is desired to generate bridges before pf/ipfw are generated. Likewise for iscsi attachments to work, vm auto-booting should be after NETWORKING.
Split into vm_net (early / bridge generation) and vm (late / vm start as well as shutdown) phases/rc.d files. This allows non-circular ordering of dependencies.
We don't currently have a clean way to stop and restart the 'init' phase, especially in light of potentially needing to reload firewalls rules.
This still uses the same vm_enable rcvar, so there is no change in "user interface"