Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPENDENCY: update to latest ember-cli/babel #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toranb
Copy link
Contributor

@toranb toranb commented May 22, 2018

Overview

This PR updates the dependencies and solves a deprecation warning users of ember-cli get when installing this

Summary

To remove the deprecation warning for users of ember-cli

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have evaluated if the README.md documentation needs to be updated
  • I have evaluated if the /tests/dummy/ app needs to be modified
  • I have evaluated if DocBlock headers needed to be added or updated
  • I have verified that lint and tests pass locally with my changes
  • If a fork of a dependent package had to be made to address the issue this PR closes:
    • I noted in the fork's README.md the reason the fork was created
    • I have opened an upstream issue detailing what was deficient about the dependency
    • I have opened an upstream PR addressing this deficiency
    • I have opened an issue in this repository to track this PR and schedule the removal of the usage of the fork

Semver

This project uses semver, please check the scope of this PR:

  • #none#
  • #patch#
  • #minor#
  • #major#

CHANGELOG

DEPENDENCY: update to latest ember-cli/babel

@toranb toranb requested review from a team as code owners May 22, 2018 12:04
@toranb toranb mentioned this pull request May 22, 2018
12 tasks
@toranb
Copy link
Contributor Author

toranb commented Jun 6, 2018

@juwara0 -anyone available to review and merge this at some point in June?

@notmessenger
Copy link
Contributor

@toranb June is achievable. I also left a comment at #64 (comment) about the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants