-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed selectItem to send an array of values to the onChange #576
base: master
Are you sure you want to change the base?
Conversation
Once you merge this the following repositories MUST ALSO BE UPDATED and new majors released, in the order they are listed: ember-frost-popover |
Your development process/flow should be to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests
@helrac I had disabled the protected branch status of this repo 2 days ago in anticipation of you merging this PR but since you haven't yet I have re-enabled it. You will need to reach out to @juwara0 or myself (as usual) before merging this PR so that we can re-temporarily-disable it before you merge this PR. |
@helrac And you need to merge in the latest changes from |
Overview
Does this PR close an existing issue?
This closes #575
Summary
Changed the selectItem to pass in an array of values instead of just to the value to the specified onChange
Issue Number(s)
Screenshots or recordings
Checklist
Semver
This project uses semver, please check the scope of this PR:
CHANGELOG