Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed selectItem to send an array of values to the onChange #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

helrac
Copy link
Contributor

@helrac helrac commented Jun 18, 2018

Overview

Does this PR close an existing issue?

This closes #575

Summary

Changed the selectItem to pass in an array of values instead of just to the value to the specified onChange

Issue Number(s)

Screenshots or recordings

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have evaluated if the README.md documentation needs to be updated
  • I have evaluated if the /tests/dummy/ app needs to be modified
  • I have evaluated if DocBlock headers needed to be added or updated
  • I have verified that lint and tests pass locally with my changes

Semver

This project uses semver, please check the scope of this PR:

  • #none#
  • #patch#
  • #minor#
  • #major#

CHANGELOG

  • Changed selectItem to pass an array of values to the onChange instead of just the value

@helrac helrac requested a review from a team as a code owner June 18, 2018 16:04
@notmessenger
Copy link
Contributor

notmessenger commented Jun 18, 2018

Once you merge this the following repositories MUST ALSO BE UPDATED and new majors released, in the order they are listed:

ember-frost-popover
ember-frost-demo-components
ciena-icons
ember-frost-action-bar
ember-frost-date-picker
ember-frost-fields
ember-frost-table
ember-frost-tabs
ember-frost-bunsen
ember-frost-chart
ember-frost-file-picker
ember-frost-info-bar
ember-frost-list
ember-frost-modal
ember-frost-navigation
ember-frost-notifier
ember-frost-object-browser
ember-frost-object-details
ember-frost-sort
ember-frost-pick-list
ember-frost-sidebar
frost-foundation

@notmessenger
Copy link
Contributor

notmessenger commented Jun 18, 2018

Your development process/flow should be to run npm run test locally before opening a PR so that you do not waste the CI environment's resources telling you that you have failing tests that you could have discovered on your own more easily and faster.

Copy link
Contributor

@notmessenger notmessenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests

@notmessenger
Copy link
Contributor

@helrac I had disabled the protected branch status of this repo 2 days ago in anticipation of you merging this PR but since you haven't yet I have re-enabled it. You will need to reach out to @juwara0 or myself (as usual) before merging this PR so that we can re-temporarily-disable it before you merge this PR.

@notmessenger
Copy link
Contributor

@helrac And you need to merge in the latest changes from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete should return an array of values instead of the just a value
2 participants