daemon, option: Fix vlan bpf bypass ids loading #20282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pippolo84
force-pushed
the
pr/pippolo84/fix-helm-vlan-bpf-bypass-value-loading
branch
from
7815a69 to
00b14d1
Compare
pippolo84
changed the title
pippolo84
added
kind/bug
pippolo84
force-pushed
the
pr/pippolo84/fix-helm-vlan-bpf-bypass-value-loading
branch
from
00b14d1 to
aac1500
Compare
|
/test |
sayboras
reviewed
Jun 23, 2022
There was a problem hiding this comment.
Couple of small comments as per below.
This is the only one we are using int slice, and unlikely we have int slice in future, so up to you if you want to add something similar to https://github.com/cilium/cilium/blob/master/contrib/scripts/check-viper-get-string-map-string.sh
kaworu
approved these changes
Jun 23, 2022
pippolo84
added a commit
to pippolo84/cilium
that referenced
this pull request
Jun 28, 2022
Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to cilium#20282 Signed-off-by: Fabio Falzoi <[email protected]>
qmonnet
pushed a commit
that referenced
this pull request
Jun 30, 2022
Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to #20282 Signed-off-by: Fabio Falzoi <[email protected]>
aanm
approved these changes
Jun 30, 2022
|
/test |
|
/test-1.24-net-next Job 'Cilium-PR-K8s-GKE' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
christarazi
approved these changes
Jul 1, 2022
rolinh
reviewed
Jul 5, 2022
It's not a breaking change. The old syntax and Helm value just simply never worked, it was a complete no-op. |
rolinh
approved these changes
Jul 5, 2022
pippolo84
added
the
ready-to-merge
qmonnet
pushed a commit
that referenced
this pull request
Jul 5, 2022
[ upstream commit 98280fa ] Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to #20282 Signed-off-by: Fabio Falzoi <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
pushed a commit
that referenced
this pull request
Jul 5, 2022
[ upstream commit 98280fa ] Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to #20282 Signed-off-by: Fabio Falzoi <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
ldelossa
approved these changes
Jul 6, 2022
ti-mo
added
backport-done/1.11
ti-mo
pushed a commit
that referenced
this pull request
Jul 13, 2022
[ upstream commit 98280fa ] Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to #20282 Signed-off-by: Fabio Falzoi <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
ti-mo
added
backport-done/1.12
gandro
pushed a commit
to gandro/cilium
that referenced
this pull request
Aug 4, 2022
[ upstream commit 98280fa ] Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to cilium#20282 Signed-off-by: Fabio Falzoi <[email protected]> Signed-off-by: Quentin Monnet <[email protected]> Signed-off-by: Michi Mutsuzaki <[email protected]>
dezmodue
pushed a commit
to dezmodue/cilium
that referenced
this pull request
Aug 10, 2022
Through the ConfigMap, all config values are loaded as strings and then converted into the appropriate types. The conversion is carried out by Viper that does not report any kind of error if something goes wrong. To catch early any kind of conversion issue, we should use the same conversion APIs that Viper is using internally, so we check each option using the appropriate conversion function from the cast package. Related to cilium#20282 Signed-off-by: Fabio Falzoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing cilium-agent via Helm, the configuration options are loaded reading files.
Each file represents an entry in the ConfigMap.
Doing so, all the values are loaded as strings and therefore must be converted to the specific option value type later.
This conversion is carried out by the spf13/viper package itself.
Internally, viper tries to load values from different sources:
When loading values from a config file, unlike the flag code path, the conversion from string to the requested value type is carried out by the spf13/cast package.
The cast package does not support the conversion from string to slice of ints and the viper.GetIntSlice(...) function does not report any error if the conversion goes wrong.
As a temporary workaround, the bpf.vlanBypass option value type has been changed to a slice of strings, so to leave the conversion to a slice of ints to be implemented manually.
To avoid this workaround, two things are needed:
validateConfigmapfunction to check option values using the cast package with the proper type conversion, instead of relying on pflagSetmethod.Fixes: #20173