Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpatch: Remove grouping logs in GHA output #236

Merged
merged 1 commit into from
Feb 15, 2024
Merged

checkpatch: Remove grouping logs in GHA output #236

merged 1 commit into from
Feb 15, 2024

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Feb 14, 2024

Grouping logs by commit in the output of the GitHub workflow provides a nicer interface than just displaying separators, but it turns out to be more cumbersome in case of errors, because users have no way to know what group contains the error and they have to manually expand all groups, which has proved annoying. There doesn't seem to be an option to auto-expand the groups, so let's remove them altogether.

Grouping logs by commit in the output of the GitHub workflow provides a
nicer interface than just displaying separators, but it turns out to be
more cumbersome in case of errors, because users have no way to know
what group contains the error and they have to manually expand all
groups, which has proved annoying. There doesn't seem to be an option to
auto-expand the groups, so let's remove them altogether.

Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet requested a review from a team as a code owner February 14, 2024 12:26
@qmonnet qmonnet merged commit 70d73bc into cilium:master Feb 15, 2024
1 check passed
@qmonnet qmonnet deleted the pr/checkpatch-no-group branch February 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants