startup-script: Adjust ca-certificates install to only copy certs #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the method in which `ca-certificates` is installed into the startup-script image. The `ca-certificates` package has a dependency on OpenSSL, which unnecessarily increases the attack surface of the image, since the image's only functionality is fully contained in `manage-startup-script.sh` and the script makes no network connections. The package could theoretically be removed, but as a precaution, the root certificates from the `ca-certificates` package are copied in to the image using the same method as is used in the Cilium Operator image. Signed-off-by: Ryan Drew <[email protected]>
learnitall
force-pushed
the
pr/learnitall/startup-script-ca-certificates
branch
from
a3156f2
to
eb5e8f8
Compare
This commit adds two missing environment variables that allow for anonymous authentication to remote registries when pushing build results is disabled. Pulls and remote digest checks are read-only operations that do not require credentials, however however, if credentials are not set during a non-push build, some steps may return an error that looks like this: ``` sha256:0e59c8168a48aa9ed0573be2d38d40a95e1b1635877d6e3dd56dfd33e3597e56 pulling image moby/buildkit:buildx-stable-1 done ERROR: error getting credentials - err: exit status 1, out: `ANY_REGISTRY_USERNAME is not set` ``` The above example was triggered while building the `image-maker` image in the call to `docker buildx build`. This bug prevents PRs from forks from running the "Build all images" workflow to test their changes, making it more difficult for members of the community who don't have write access to this repository to open PRs. Signed-off-by: Ryan Drew <[email protected]>
learnitall
force-pushed
the
pr/learnitall/startup-script-ca-certificates
branch
from
eb5e8f8
to
2577810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits, one for adjusting the way we install
ca-certificatesin thestartup-scriptimage, and one to enable image builds in PRs from forks. Please see individual commits for details.I opened a draft PR in
cilium/ciliumto test the changes to this image, see cilium/cilium#33414. The helm-based checks are failing because I didn't update the generated documentation. All other checks that actually use the newstartup-scriptimage are passing.