-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update readme after new tagging mechanic #294
Fix: update readme after new tagging mechanic #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits in the wording, but looks good otherwise, thanks!
thank you, applied the fix ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! For future PRs, please squash the two commits together (do keep logical commits in the PR, but review fixes should not stand out as separate commits), and no need to keep the co-authored-by
for trivial review fixes 🙂
Following the pr cilium#286, update of the readme about how the tagging mechanic works Signed-off-by: Antony Reynaud <[email protected]>
e11301c
to
1abadf1
Compare
fixed that too, thanks a lot for the review ! |
I can't merge without the missing reviews. I'll request one from Tobias, as I think Daniel is out. |
Following the pr #286, update of the README.md about how the tagging mechanic works