Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update readme after new tagging mechanic #294

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Artyop
Copy link
Contributor

@Artyop Artyop commented Aug 5, 2024

Following the pr #286, update of the README.md about how the tagging mechanic works

@Artyop Artyop requested a review from a team as a code owner August 5, 2024 15:58
@Artyop Artyop requested a review from borkmann August 5, 2024 15:58
@nbusseneau nbusseneau requested a review from qmonnet August 6, 2024 12:27
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits in the wording, but looks good otherwise, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Artyop
Copy link
Contributor Author

Artyop commented Aug 6, 2024

Small nits in the wording, but looks good otherwise, thanks!

thank you, applied the fix !

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! For future PRs, please squash the two commits together (do keep logical commits in the PR, but review fixes should not stand out as separate commits), and no need to keep the co-authored-by for trivial review fixes 🙂

Following the pr cilium#286, update of the readme about how the
tagging mechanic works

Signed-off-by: Antony Reynaud <[email protected]>
@Artyop Artyop force-pushed the pr/fix-readme-new-tagging-mechanic branch from e11301c to 1abadf1 Compare August 7, 2024 08:24
@Artyop
Copy link
Contributor Author

Artyop commented Aug 7, 2024

Thank you! For future PRs, please squash the two commits together (do keep logical commits in the PR, but review fixes should not stand out as separate commits), and no need to keep the co-authored-by for trivial review fixes 🙂

fixed that too, thanks a lot for the review !

@qmonnet
Copy link
Member

qmonnet commented Aug 7, 2024

I can't merge without the missing reviews. I'll request one from Tobias, as I think Daniel is out.

@qmonnet qmonnet requested a review from tklauser August 7, 2024 09:40
@tklauser tklauser merged commit 53113e8 into cilium:master Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants