bpf_metadata: set TCP keep alive socket options without Envoy SocketOption #1151
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption PR cilium#1115 unintentionally changed that the keep alive socket options are no longer applied on the accepted downstream socket, instead (due to the usage of Envoy SocketOption) they are now applied on the corresponding upstream socket. This commit is reverting this change and adds some helping comments to the code. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
commented
Jan 28, 2025
jrajahalme
approved these changes
Jan 28, 2025
mhofstetter
deleted the
pr/mhofstetter/revert-tcp-keepalive-socketoption
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1115 unintentionally changed that the keep alive socket options are no longer applied on the accepted downstream socket, instead (due to the usage of Envoy SocketOption) they are now applied on the corresponding upstream socket.
This commit is reverting this change and adds some helping comments to the code.
Note: Same would have applied for
SO_LINGER- but this has been removed completely in the meantime with #1128