logging: use ENVOY_(CONN_)LOG with logger ID instead of ENVOY_LOG_MISC #1153
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENVOY_LOG_MISC should be used where no logger ID is available. The BPFMetadata listener filter uses the logger ID `filter` and should make use of this by using `ENVOY_LOG`. This helps when filtering log messages by logger IDs. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
changed the title
ENVOY_LOG_MISC should be used where no logger ID is available. The SslSocketWrapper uses a logger ID and should make use of this by using `ENVOY_CONN_LOG`. This helps when filtering log messages by logger IDs. In addition, this commit changes the current logger instance `config` to `connection` - which is also used by the upstream Envoy TransportSocket implementations. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/log-filter-ids
branch
from
9b9b1c4 to
3a24424
Compare
mhofstetter
changed the title
jrajahalme
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits