Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: docs, trnasform events into single page #1616

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jrfastab
Copy link
Contributor

I don't like these multi page click icons lets just build a single page for events.

I don't like these multi page click icons lets just build a single page
for events.

Signed-off-by: John Fastabend <[email protected]>
@jrfastab jrfastab requested review from mtardy and a team as code owners October 18, 2023 23:41
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit bbce254
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65316008b13d8e0008f85449
😎 Deploy Preview https://deploy-preview-1616--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jrfastab jrfastab force-pushed the pr/jrfastab/docs-events branch from 95e134f to 57d3347 Compare October 18, 2023 23:41
@kkourt kkourt added the release-note/docs This PR updates the documentation. label Oct 19, 2023
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I completely agree, I didn't understand where this split came from originally :)!

If you have time, I have some comments however.

docs/content/en/docs/concepts/events.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/events.md Outdated Show resolved Hide resolved
`GOOS`/`GOARCH` binary releases.

To start printing events run:
```shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```shell
```shell-session

docs/content/en/docs/concepts/events.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/events.md Outdated Show resolved Hide resolved
set from helm with the `tetragon.grpc.address` flag or disabled completely if
needed with `tetragon.grpc.enabled`.

```shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```shell
```shell-session

docs/content/en/docs/concepts/events.md Outdated Show resolved Hide resolved
@jrfastab jrfastab force-pushed the pr/jrfastab/docs-events branch from 57d3347 to bbce254 Compare October 19, 2023 16:57
@jrfastab
Copy link
Contributor Author

thanks Mahe I think I resolved your comments.

@jrfastab jrfastab merged commit 1f4ca86 into main Oct 19, 2023
9 checks passed
@jrfastab jrfastab deleted the pr/jrfastab/docs-events branch October 19, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants