-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: docs, trnasform events into single page #1616
Conversation
I don't like these multi page click icons lets just build a single page for events. Signed-off-by: John Fastabend <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
95e134f
to
57d3347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I completely agree, I didn't understand where this split came from originally :)!
If you have time, I have some comments however.
`GOOS`/`GOARCH` binary releases. | ||
|
||
To start printing events run: | ||
```shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```shell | |
```shell-session |
set from helm with the `tetragon.grpc.address` flag or disabled completely if | ||
needed with `tetragon.grpc.enabled`. | ||
|
||
```shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```shell | |
```shell-session |
57d3347
to
bbce254
Compare
thanks Mahe I think I resolved your comments. |
I don't like these multi page click icons lets just build a single page for events.