helm: add service monitor scrape interval config #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-R-lantern
force-pushed
the
ISSUE-1633/Make-service-monitor-scrape-interval-configurable-in-helm-chart
branch
from
f710f8f to
560bf15
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jack-R-lantern
force-pushed
the
ISSUE-1633/Make-service-monitor-scrape-interval-configurable-in-helm-chart
branch
from
560bf15 to
52f1607
Compare
lambdanis
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Thank you for the PR @Jack-R-lantern
I would simplify the Helm values to have:
serviceMonitor:
scrapeInterval: "10s"
It's pretty to common to configure ServiceMonitors like that, and I find the endpoints section in Tetragon Helm values a bit confusing.
|
@lambdanis Thanks Review, I will change it |
Jack-R-lantern
force-pushed
the
ISSUE-1633/Make-service-monitor-scrape-interval-configurable-in-helm-chart
branch
from
52f1607 to
07a868a
Compare
lambdanis
added
release-note/minor
lambdanis
reviewed
Oct 23, 2023
Jack-R-lantern
force-pushed
the
ISSUE-1633/Make-service-monitor-scrape-interval-configurable-in-helm-chart
branch
from
07a868a to
cdb2611
Compare
lambdanis
reviewed
Oct 24, 2023
There was a problem hiding this comment.
@Jack-R-lantern It seems a dot in the doc slipped over ;)
I'll take a look at CI, not sure what's wrong there.
|
The CI failures seem to be a CI bug: #1646 |
this commit was related to the service monitor scrape interval option Signed-off-by: Jack-R-lantern <[email protected]>
Jack-R-lantern
force-pushed
the
ISSUE-1633/Make-service-monitor-scrape-interval-configurable-in-helm-chart
branch
from
cdb2611 to
d23547a
Compare
lambdanis
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was related to the service monitor scrape interval option.
I made a change to allow options to be injected via the values.yaml file.
fix: #1633