backport/v1.0/: bugtool gops pprofheap #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Upstream main 36cae01] This adds support to get or set the gops path. Signed-off-by: Djalal Harouni <[email protected]>
[Upstream main bae3b77] We use gops to get the pprof heap profile instead of http, as it seems that gops does not export an HTTP endpoint, and by default we do not start the pprof profiling server. The --pprof-addr is marked hidden and requiring users to listen on another port could be an overkill. Signed-off-by: Djalal Harouni <[email protected]>
[Upstream main 558d869] Signed-off-by: Djalal Harouni <[email protected]>
tixxdz
added
kind/backport
[Upstream main fff17c0] This was changed to adapt to packages-e2e tests since in upstream we removed the docker pull that was failing in CI when there are lot of PRs from contributors. We changed that to do cross compile builds. For backporting branch the number of PRs is limited. Signed-off-by: Djalal Harouni <[email protected]>
tixxdz
force-pushed
the
pr/tixxdz/backport-v1.0/bugtool-gops-pprofheap
branch
from
8351eb0 to
23249c7
Compare
willfindlay
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport to v1.0 of #2007