Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add part-of and component labels #3052

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

lambdanis
Copy link
Contributor

Also refactor the labels templates (deduplicate).

@lambdanis lambdanis added release-note/minor This PR introduces a minor user-visible change area/helm Related to the Helm chart labels Oct 25, 2024
@lambdanis lambdanis requested a review from a team as a code owner October 25, 2024 19:20
@lambdanis lambdanis requested a review from olsajiri October 25, 2024 19:20
@lambdanis lambdanis marked this pull request as draft October 25, 2024 19:28
@lambdanis lambdanis force-pushed the pr/lambdanis/helm-labels branch from 63c2d02 to 7178f9f Compare October 25, 2024 19:32
@lambdanis lambdanis marked this pull request as ready for review October 25, 2024 19:32
@lambdanis lambdanis force-pushed the pr/lambdanis/helm-labels branch from 7178f9f to bedabbb Compare October 25, 2024 19:34
There are no functional changes in this commit, only refactoring.

Signed-off-by: Anna Kapuscinska <[email protected]>
They're recommended by Kubernetes, so let's add them. See:
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Signed-off-by: Anna Kapuscinska <[email protected]>
@lambdanis lambdanis force-pushed the pr/lambdanis/helm-labels branch from bedabbb to fe56a72 Compare October 25, 2024 21:14
Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lambdanis lambdanis merged commit 3da7dc2 into cilium:main Oct 29, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Related to the Helm chart release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants