Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use label match in SERVICECIDR command for KinD #3216

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tiswanso
Copy link
Contributor

Fixes #3182

Description

Use component=kube-apiserver match in doc command for getting the SERVICECIDR on KinD clusters

Named KinD clusters will have kube-apiserver pods with the cluster name included--the format is kube-apiserver-<CLUSTERNAME>-control-plane. The kube-system control-plane uses the label component=kube-apiserver on the apiserver pods regardless of the cluster name.

Use `component=kube-apiserver` match in doc command for KinD clusters

- Named KinD clusters will have kube-apiserver pods with the cluster name included--the format is `kube-apiserver-<CLUSTERNAME>-control-plane`.  The kube-system control-plane uses the label `component=kube-apiserver` on the apiserver pods.

Fixes cilium#3182

Signed-off-by: Tim Swanson <[email protected]>
@tiswanso tiswanso requested review from mtardy and a team as code owners December 12, 2024 14:37
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit f3459f4
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/675af52fea56ec0008dc8b30
😎 Deploy Preview https://deploy-preview-3216--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Dec 12, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's a great fix, it actually fix the situation in the case you used make kind-setup so that's cool.

@mtardy mtardy merged commit f966024 into cilium:main Dec 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Network Monitoring SERVICECIDR command for KinD doesn't work for named clusters
2 participants