tests: replace panic with t.Fatal #3287
Merged
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panicking in tests is bad as it fails to tell the test handler that the test failed. Instead we should use t.Fatal(). This commit changes instances of panic in tests to t.Fatal(). [Upstream commit: ae2f3c1] Signed-off-by: Kevin Sheldrake <[email protected]>
Use the output returned by Fatal instead of passing stuff to printf [Upstream commit: 057d734] Signed-off-by: Mahe Tardy <[email protected]>
kevsecurity
added
the
release-note/misc
kevsecurity
force-pushed
the
backports/kevsecurity/v1.1/change-panic-to-fatal-in-tests
branch
2 times, most recently
from
b88cd0e to
d3fccfc
Compare
For the base image to have nc.openbsd, see cilium/little-vm-helper-images@2af406c. Signed-off-by: Mahe Tardy <[email protected]>
kevsecurity
force-pushed
the
backports/kevsecurity/v1.1/change-panic-to-fatal-in-tests
branch
from
d3fccfc to
a1c5438
Compare
kevsecurity
requested review from
will-isovalent
and removed request for
a team
will-isovalent
approved these changes
Jan 9, 2025
kevsecurity
deleted the
backports/kevsecurity/v1.1/change-panic-to-fatal-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panicking in tests is bad as it fails to tell the test handler that the test failed. Instead we should use t.Fatal(). This commit changes instances of panic in tests to t.Fatal().
[Upstream PR: #2685]