-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt CISQLite3.build.cs to changes since UE 4.16 #10
Open
Squareys
wants to merge
25
commits into
cindustries:master
Choose a base branch
from
Squareys:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the plugin compatible with UE 4.19. Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
I added some more cleanup commits and updated sqlite to newest stable version. |
Fixes cindustries#7. Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Allows queries like `SELECT last_insert_rowid()` after an insert, which would otherwise always return 0 because the state is reset with open and close. Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Loads of warnings for over 200 symbols along the lines of > is not defined as a preprocessor macro, replacing with '0' for '#if/#elif' prevented compilation because that warning is treaded as an error as of UE4.20. Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Avoids a clash with similar methods from UObject base class. Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
Kaninchen221
reviewed
Feb 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Thank you for creating this plugin! I made a minor change to make this plugin compatible with UE 4.19. Would be great, if you could merge this upstream.
Cheers, Jonathan.