Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust crypto instead of libolm #1965

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Use rust crypto instead of libolm #1965

wants to merge 10 commits into from

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Sep 20, 2024

Description

Fixes #1869

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@ajbura ajbura marked this pull request as draft September 20, 2024 16:11
@nyabinary

This comment was marked as off-topic.

@marekvospel
Copy link

@ajbura I took a look at why this error was ocurring. Found this npm/cli#4828. Regenerating the package-lock.json as advised has worked. Also vite-plugin-top-level-await needs to be updated to v1.4.2. (see Menci/vite-plugin-top-level-await#52)

Also looking at fe4d0be, there are some duplicate lines, so changes of that commit might need to be revised.

I have done these changes (https://github.com/marekvospel/cinny/commits/js-sdk-v34/), and the build started passing. (I am seeing a lot of IndexedDBStore failure, degrading to MemoryStore TypeError: this.db is undefined errors in the console though, so there might be more needed to get this to work correctly)

I hope this isn't too bold move from me. Since this is a security concern, I'd love this to be resolved as fast as possible, and this PR seemed stale. Feel free to contact me if there is anything I can help with 😉 @marek:vospel.cz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move from libolm to vodozemac due to deprecation
3 participants