-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription prime bugfixes #1
base: subscription-prime
Are you sure you want to change the base?
Subscription prime bugfixes #1
Conversation
This allows the caller to complete their pubsub call before the prime function, avoiding data races.
Sorry seems like I misunderstood what prime was doing, it is apparently much more specific then I understood it to be. |
6601cc5
to
a9c8f7b
Compare
a9c8f7b
to
6601cc5
Compare
6df2529
to
f7a0f09
Compare
Hey, I checked out your branch!
With the two changes that I made it works good for me - though the second change is an issue that probably creates more problems then it solves.
The first fix is just a trivial fix that handles an oversight: In absinthe you can have a GraphQL query that returns a single element instead of a list, the way the code worked before it was assuming that its a list, just added the case and that fixed the problem.
The second thing is that I commented out the line in get_ordinal because it causes problems for me.
And since I do not use the ordinal feature I can not properly test it for you so I will refrain from changing anything here beyond disabling the feature.
The reason why this causes a problem is that I (and I assume many others) have side effects in their subscription config function.
And this causes it to be called multiple times. This breaks my entire app and will probably have to be
done differently unless you want the library to have breaking changes for many users. Probably it can be solved by passing the ordinal callback to the options in the same way you handle it for prime, though it seems to me ordinal is handled in a bit more complex way then prime, and is dispatched in ways that I would need some time to understand, which is why I refrained from changing the logic and just commented it out to make the branch work for my project.
Other then that it is great and does what its supposed to do, if other issues arise I will report.
Best