Update module to stay compatible with SimpleSAMLphp and PHP 8.3+ #64
tvdijenphp.yml
on: pull_request
Annotations
10 errors and 1 warning
|
MissingClassConstType:
src/Auth/Source/RateLimitUserPass.php#L45
src/Auth/Source/RateLimitUserPass.php:45:19: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Auth\Source\RateLimitUserPass::DEFAULT_CONFIG" should have a declared type. (see https://psalm.dev/359)
|
|
UnusedMethodCall:
src/Auth/Source/RateLimitUserPass.php#L103
src/Auth/Source/RateLimitUserPass.php:103:22: UnusedMethodCall: The call to ReflectionMethod::setAccessible is not used (see https://psalm.dev/209)
|
|
MixedPropertyTypeCoercion:
src/Limiters/IpLimiter.php#L26
src/Limiters/IpLimiter.php:26:28: MixedPropertyTypeCoercion: $this->whitelist expects 'array<array-key, string>', parent type `array<array-key, mixed>` provided (see https://psalm.dev/196)
|
|
MissingClassConstType:
src/Limiters/UserPassBaseLimiter.php#L17
src/Limiters/UserPassBaseLimiter.php:17:21: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::PREAUTH_ALLOW" should have a declared type. (see https://psalm.dev/359)
|
|
MissingClassConstType:
src/Limiters/UserPassBaseLimiter.php#L18
src/Limiters/UserPassBaseLimiter.php:18:21: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::PREAUTH_BLOCK" should have a declared type. (see https://psalm.dev/359)
|
|
MissingClassConstType:
src/Limiters/UserPassBaseLimiter.php#L19
src/Limiters/UserPassBaseLimiter.php:19:21: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::PREAUTH_CONTINUE" should have a declared type. (see https://psalm.dev/359)
|
|
InvalidFalsableReturnType:
src/Limiters/UserPassBaseLimiter.php#L112
src/Limiters/UserPassBaseLimiter.php:112:33: InvalidFalsableReturnType: The declared return type 'SimpleSAML\Store\StoreInterface' for SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::getStore does not allow false, but 'SimpleSAML\Store\StoreInterface|false' contains false (see https://psalm.dev/143)
|
|
FalsableReturnStatement:
src/Limiters/UserPassBaseLimiter.php#L118
src/Limiters/UserPassBaseLimiter.php:118:16: FalsableReturnStatement: The declared return type 'SimpleSAML\Store\StoreInterface' for SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::getStore does not allow false, but the function returns 'SimpleSAML\Store\StoreInterface|false' (see https://psalm.dev/137)
|
|
UnusedMethodCall:
tests/src/Auth/Process/LoopDetectionTest.php#L64
tests/src/Auth/Process/LoopDetectionTest.php:64:16: UnusedMethodCall: The call to ReflectionProperty::setAccessible is not used (see https://psalm.dev/209)
|
|
Quality control
Process completed with exit code 2.
|
|
PropertyNotSetInConstructor:
tests/src/Limiters/DeviceCookieLimiterTest.php#L20
tests/src/Limiters/DeviceCookieLimiterTest.php:20:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest::$mockHttp is not defined in constructor of SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|