Skip to content

Update module to stay compatible with SimpleSAMLphp and PHP 8.3+ #70

Update module to stay compatible with SimpleSAMLphp and PHP 8.3+

Update module to stay compatible with SimpleSAMLphp and PHP 8.3+ #70

Triggered via pull request May 9, 2024 13:17
Status Failure
Total duration 1m 40s
Artifacts

php.yml

on: pull_request
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
0s
Code coverage
Cleanup artifacts
0s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 1 warning
MissingClassConstType: src/Auth/Source/RateLimitUserPass.php#L46
src/Auth/Source/RateLimitUserPass.php:46:19: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Auth\Source\RateLimitUserPass::DEFAULT_CONFIG" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: src/Limiters/UserPassBaseLimiter.php#L18
src/Limiters/UserPassBaseLimiter.php:18:21: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::PREAUTH_ALLOW" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: src/Limiters/UserPassBaseLimiter.php#L21
src/Limiters/UserPassBaseLimiter.php:21:21: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::PREAUTH_BLOCK" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: src/Limiters/UserPassBaseLimiter.php#L24
src/Limiters/UserPassBaseLimiter.php:24:21: MissingClassConstType: Class constant "SimpleSAML\Module\ratelimit\Limiters\UserPassBaseLimiter::PREAUTH_CONTINUE" should have a declared type. (see https://psalm.dev/359)
Quality control
Process completed with exit code 2.
PropertyNotSetInConstructor: tests/src/Limiters/DeviceCookieLimiterTest.php#L20
tests/src/Limiters/DeviceCookieLimiterTest.php:20:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest::$mockHttp is not defined in constructor of SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest or in any private or final methods called in the constructor (see https://psalm.dev/074)