Skip to content

Update module to stay compatible with SimpleSAMLphp and PHP 8.3+ #73

Update module to stay compatible with SimpleSAMLphp and PHP 8.3+

Update module to stay compatible with SimpleSAMLphp and PHP 8.3+ #73

Triggered via pull request May 9, 2024 13:53
Status Failure
Total duration 3m 3s
Artifacts

php.yml

on: pull_request
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
0s
Code coverage
Cleanup artifacts
0s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 6 warnings
MissingFile: tests/docker/public/looping-login.php#L6
tests/docker/public/looping-login.php:6:1: MissingFile: Cannot find file /home/runner/work/simplesamlphp-module-ratelimit/simplesamlphp-module-ratelimit/_include.php to include (see https://psalm.dev/107)
Quality control
Process completed with exit code 2.
Unit tests, PHP 8.3, ubuntu-latest
Process completed with exit code 1.
PropertyNotSetInConstructor: tests/src/Limiters/DeviceCookieLimiterTest.php#L21
tests/src/Limiters/DeviceCookieLimiterTest.php:21:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest::$mockHttp is not defined in constructor of SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
PossiblyUndefinedGlobalVariable: tests/docker/config-override.php#L5
tests/docker/config-override.php:5:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $config, first seen on line 5 (see https://psalm.dev/126)
PossiblyUndefinedGlobalVariable: tests/docker/metadata/saml20-idp-hosted.php#L9
tests/docker/metadata/saml20-idp-hosted.php:9:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 9 (see https://psalm.dev/126)
PossiblyUndefinedGlobalVariable: tests/docker/metadata/saml20-idp-remote.php#L3
tests/docker/metadata/saml20-idp-remote.php:3:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 3 (see https://psalm.dev/126)
PossiblyUndefinedGlobalVariable: tests/docker/metadata/saml20-sp-remote.php#L3
tests/docker/metadata/saml20-sp-remote.php:3:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 3 (see https://psalm.dev/126)
PropertyNotSetInConstructor: tests/src/Limiters/DeviceCookieLimiterTest.php#L21
tests/src/Limiters/DeviceCookieLimiterTest.php:21:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest::$mockHttp is not defined in constructor of SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest or in any private or final methods called in the constructor (see https://psalm.dev/074)