Skip to content

Commit

Permalink
Allow psalm to fail for the tests-directory
Browse files Browse the repository at this point in the history
  • Loading branch information
tvdijen committed May 9, 2024
1 parent ec676f9 commit 3b3419b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,14 @@ jobs:
run: phpcs

- name: Psalm
continue-on-error: true
run: |
psalm -c psalm.xml \
--show-info=true \
--shepherd \
--php-version=${{ steps.setup-php.outputs.php-version }}
- name: Psalm (testsuite)
continue-on-error: true
run: |
psalm -c psalm-dev.xml \
--show-info=true \
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Limiters/DeviceCookieLimiterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
class DeviceCookieLimiterTest extends TestCase
{
/**
* @var MockObject|HTTP
* @var \PHPUnit\Framework\MockObject\MockObject|\SimpleSAML\Utils\HTTP
*/
private $mockHttp;

Check warning on line 20 in tests/src/Limiters/DeviceCookieLimiterTest.php

View workflow job for this annotation

GitHub Actions / Quality control

PropertyNotSetInConstructor

tests/src/Limiters/DeviceCookieLimiterTest.php:20:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest::$mockHttp is not defined in constructor of SimpleSAML\Test\Module\ratelimit\Limiters\DeviceCookieLimiterTest or in any private or final methods called in the constructor (see https://psalm.dev/074)

Expand Down

0 comments on commit 3b3419b

Please sign in to comment.