Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ModuleName "Microsoft.Graph.Beta.Applications" from RequiredVersions.ps1 #1590

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mitchelbaker-cisa
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa commented Feb 21, 2025

🗣 Description

RequiredVersions.ps1 references the same module twice. This PR removes the duplicate instance.

💭 Motivation and context

Closes #1589

🧪 Testing

  • Ran Initialize-SCuBA with no error
  • Ran Invoke-SCuBA in interactivel/noninteractive with no error
  • Ran smoke test

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
    - [ ] Unit tests added/updated to cover PowerShell and Rego changes.
    - [ ] Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would also be to move the other Graph Beta Applications block above powershell-yaml to keep all the Graph Modules in straight install line.

@mitchelbaker-cisa mitchelbaker-cisa self-assigned this Feb 21, 2025
@mitchelbaker-cisa mitchelbaker-cisa added the bug This issue or pull request addresses broken functionality label Feb 21, 2025
@mitchelbaker-cisa mitchelbaker-cisa added this to the Marlin milestone Feb 21, 2025
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good. Ran branch with Initialize-SCuBA successfully along with non-interactive and interactive full runs of ScubaGear without issue.
Update looks good.

@mitchelbaker-cisa
Copy link
Collaborator Author

@nanda-katikaneni read to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate ModuleName "Microsoft.Graph.Beta.Applications" from RequiredVersions.ps1
3 participants