Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunset frontend code for ReadySetCyber (CRASM-807, 808, 809) #722

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Nov 12, 2024

  • Removes all frontend code related to the Ready Set Cyber Dashboard project.

🗣 Description

  • Deleted ReadySetCyber directory from frontend/src/components.
  • Deleted ReadySetCyber routes from frontend/src/App.tsx.
  • Deleted ReadySetCyber conditional rendering from frontend/src/components/Layout.tsx.
  • Removed RSC directory from docs/src/documentation-pages.
  • Removed RSC related code in gatsby-config.js.
  • Removed RSC cors origin from frontend/scripts/api.js.
  • Removed commented out conditionals in frontend/src/components/Layout.tsx.
  • Removed imports, logic, and components related to RSC in frontend/src/components/RouteGuard.tsx.
  • Removed readySetCyber from userType in frontend/src/types/user.ts.
  • Removed readySetCyber from userFormValues in frontend/src/types/user.ts.
  • Removed readySetCyber from user levels in frontend/src/hooks/useUserLevel.ts.

💭 Motivation and context

  • Removes all frontend code for the RSC Dashboard project as it is no longer apart of the CyHy Dashboard.
  • Closes CRASM-807
  • Closes CRASM-808
  • Closes CRASM-809

🧪 Testing

  • Repopulated local db with RSC data and began deleting components and logic.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Deleted all frontend code for ReadySetCyber.
- Deleted ReadySetCyber directory from frontend/src/components.
- Deleted ReadySetCyber routes from frontend/src/App.tsx.
- Deleted ReadySetCyber conditional rendering from frontend/src/components/Layout.tsx.
- Removed RSC directory from docs/src/documentation-pages.
- All documentation pages and images related to RSC have been removed.
- Removed RSC related code in gatsby-config.js.
- Removed RSC cors origin from frontend/scripts/api.js.
- Removed commented out conditionals in frontend/src/components/Layout.tsx.
- Removed imports, logic, and components related to RSC in frontend/src/components/RouteGuard.tsx.
- Removed readySetCyber from userType in frontend/src/types/user.ts.
- Removed readySetCyber from userFormValues in frontend/src/types/user.ts.
- Removed readySetCyber from user levels in frontend/src/hooks/useUserLevel.ts.
Copy link
Collaborator

@jayjaybunce jayjaybunce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality and visual consistency across the app. LGTM

Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per code review 11/15/24

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants