-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunset frontend code for ReadySetCyber (CRASM-807, 808, 809) #722
base: develop
Are you sure you want to change the base?
Conversation
- Deleted all frontend code for ReadySetCyber. - Deleted ReadySetCyber directory from frontend/src/components. - Deleted ReadySetCyber routes from frontend/src/App.tsx. - Deleted ReadySetCyber conditional rendering from frontend/src/components/Layout.tsx.
- Removed RSC directory from docs/src/documentation-pages. - All documentation pages and images related to RSC have been removed. - Removed RSC related code in gatsby-config.js. - Removed RSC cors origin from frontend/scripts/api.js. - Removed commented out conditionals in frontend/src/components/Layout.tsx. - Removed imports, logic, and components related to RSC in frontend/src/components/RouteGuard.tsx. - Removed readySetCyber from userType in frontend/src/types/user.ts. - Removed readySetCyber from userFormValues in frontend/src/types/user.ts. - Removed readySetCyber from user levels in frontend/src/hooks/useUserLevel.ts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionality and visual consistency across the app. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM per code review 11/15/24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🗣 Description
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist