-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ReadySetCyber (RSC) from TypeScript Backend. #723
base: develop
Are you sure you want to change the base?
Conversation
Delete TypeORM models for Assessment, Category, Question, Resource, and Response Delete RSC API endpoints Delete rscSync scan Delete RSC-related imports in connection.ts, index.ts, and worker.ts Delete mission instance credentials in dev.env.example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM per code review on 11/14/24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionality across the app and didn't find any impacted functionality.
Delete TypeORM models for Assessment, Category, Question, Resource, and Response Delete RSC API endpoints
Delete rscSync scan
Delete RSC-related imports in connection.ts, index.ts, and worker.ts Delete mission instance credentials in dev.env.example
🗣 Description
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist