Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReadySetCyber (RSC) from TypeScript Backend. #723

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Nov 13, 2024

Delete TypeORM models for Assessment, Category, Question, Resource, and Response Delete RSC API endpoints
Delete rscSync scan
Delete RSC-related imports in connection.ts, index.ts, and worker.ts Delete mission instance credentials in dev.env.example

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Delete TypeORM models for Assessment, Category, Question, Resource, and Response
Delete RSC API endpoints
Delete rscSync scan
Delete RSC-related imports in connection.ts, index.ts, and worker.ts
Delete mission instance credentials in dev.env.example
@Matthew-Grayson Matthew-Grayson linked an issue Nov 13, 2024 that may be closed by this pull request
@Matthew-Grayson Matthew-Grayson self-assigned this Nov 13, 2024
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review November 13, 2024 14:42
Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per code review on 11/14/24

Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@jayjaybunce jayjaybunce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality across the app and didn't find any impacted functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ReadySetCyber Backend Code (CRASM-810/811/813)
6 participants