Merge pull request #49 from cisagov/bugfix/pin-mongoengine

Pin MongoEngine
cisagov · Mar 22, 2023 · 6953121 · 6953121
2 parents 27decea + 96b8cfb
commit 6953121
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/setup.py b/setup.py
@@ -96,7 +96,9 @@ def get_version(version_file):
         "defusedxml",
         "dnspython",
         "docopt",
-        "mongoengine >= 0.16.3",
+        # MongoEngine 0.27.0 introduces a breaking change to the mongomock
+        # connection method. See #50 for more details.
+        "mongoengine >= 0.16.3,<0.27.0",
         "python-dateutil >= 2.7.5",
         "PyYAML >=4.2b1",
         "redis >= 3.2.0",

diff --git a/src/admiral/_version.py b/src/admiral/_version.py
@@ -1,2 +1,2 @@
 """This file defines the version of this module."""
-__version__ = "1.3.0"
+__version__ = "1.3.1"
diff --git a/tests/cert_model_test.py b/tests/cert_model_test.py
@@ -51,6 +51,7 @@ def connection():
     # Third-Party Libraries
     from mongoengine import connect
 
+    # TODO: Update this connection method. See #50 for more details.
     connect(host="mongomock://localhost", alias="default")
 
 

diff --git a/tests/test_util.py b/tests/test_util.py
@@ -32,4 +32,5 @@ def test_load_config_valid():
 
 def test_connect_from_config_valid(valid_config):
     """Test that a valid configuration connects to appropriate connections."""
+    # TODO: Update this connection method. See #50 for more details.
     util.connect_from_config(valid_config)