Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Documentation Site to AWS #2368

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Move Documentation Site to AWS #2368

merged 8 commits into from
Dec 19, 2023

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Nov 3, 2023 •
edited
Loading

🗣 Description

💭 Motivation and context

See issue #2367

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson self-assigned this Nov 3, 2023
@Matthew-Grayson Matthew-Grayson linked an issue Nov 3, 2023 that may be closed by this pull request
Move Documentation Site to AWS #2367
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 3, 2023
View reviewed changes
frontend/scripts/docs.js Fixed Show resolved Hide resolved
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review November 3, 2023 16:27
@Matthew-Grayson
Copy link
Contributor Author

The python vulnerability check failure is a false positive.

cduhn17
cduhn17 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 19, 2023
View reviewed changes
frontend/scripts/api.js
Comment on lines +50 to +52
app.use((req, res) => {
res.sendFile(path.join(__dirname, '../build/index.html'));
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
Loading
, but is not rate-limited.
cduhn17
cduhn17 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit f233938 into master Dec 19, 2023
7 of 11 checks passed
@cduhn17 cduhn17 deleted the 2367-move-documentation-site-to-aws branch December 19, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace left review comments

@cduhn17 cduhn17 cduhn17 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees

@Matthew-Grayson Matthew-Grayson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Documentation Site to AWS
4 participants
@Matthew-Grayson @epicfaace @cduhn17 @aloftus23