Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend pipeline errors (missing cors package and lambda-logger) #2456

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Fix frontend pipeline errors (missing cors package and lambda-logger) #2456

merged 4 commits into from
Jan 10, 2024

Conversation

aloftus23
Copy link
Contributor

🗣 Description

Fix errors in the frontend pipeline:
https://github.com/cisagov/crossfeed/actions/runs/7476260551/job/20346410229

  1. Add cors package to the frontend pacakge.json
  2. remove lambda-logger as that will be implemented in a future PR

@aloftus23 aloftus23 self-assigned this Jan 10, 2024
@aloftus23 aloftus23 added Frontend ASM-VDB User Interface Bug Error in a software program. May cause a program to unexpectedly quit or behave in an unintended labels Jan 10, 2024
@aloftus23 aloftus23 marked this pull request as ready for review January 10, 2024 15:38
Matthew-Grayson
Matthew-Grayson approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cduhn17
cduhn17 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit 7fffae6 into master Jan 10, 2024
11 checks passed
@cduhn17 cduhn17 deleted the 2450-frontend-pipeline-fails-to-deploy-to-staging branch January 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matthew-Grayson Matthew-Grayson Matthew-Grayson approved these changes

@cduhn17 cduhn17 cduhn17 approved these changes

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

Assignees

@aloftus23 aloftus23

Labels
Bug Error in a software program. May cause a program to unexpectedly quit or behave in an unintended Frontend ASM-VDB User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloftus23 @cduhn17 @Matthew-Grayson