Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard to CORS origin to fix access issues #2588

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

nickviola
Copy link
Contributor

@nickviola nickviola commented Feb 29, 2024

🗣 Description

Add Wildcard to CORS to address errors

💭 Motivation and context

Leadership requests adding wildcard to resolve access issues for endpoints and CORS errors

🧪 Testing

Confirm CORS errors no longer exist in DMZ

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickviola nickviola merged commit 4caa4cf into master Feb 29, 2024
19 checks passed
@nickviola nickviola deleted the bugfix/update-cors-to-fix-endpoint-issues branch February 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants