Simplify script parameter check conditional logic

Co-authored-by: Nick <[email protected]>
cisagov · Aug 15, 2024 · 6dbb2e6 · 6dbb2e6
1 parent e9fd8d2
commit 6dbb2e6
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/scripts/gather_key_cyhy_metrics.sh b/scripts/gather_key_cyhy_metrics.sh
@@ -25,13 +25,7 @@ set -o nounset
 set -o errexit
 set -o pipefail
 
-if [ $# -eq 5 ]; then
-  cyhy_db_fqdn=$1
-  cyhy_reporter_fqdn=$2
-  cyhy_mongodb_uri=$3
-  cyhy_mongodb_username=$4
-  cyhy_mongodb_password=$5
-else
+if [ $# -ne 5 ]; then
   cat << END_OF_LINE
 Usage:  ${0##*/} cyhy_db_fqdn cyhy_reporter_fqdn cyhy_mongodb_uri cyhy_mongodb_username cyhy_mongodb_password
 
@@ -45,6 +39,12 @@ END_OF_LINE
   exit 1
 fi
 
+cyhy_db_fqdn=$1
+cyhy_reporter_fqdn=$2
+cyhy_mongodb_uri=$3
+cyhy_mongodb_username=$4
+cyhy_mongodb_password=$5
+
 today=$(date +%Y-%m-%d)
 
 # COMMANDER MAIN LOOP DURATION METRICS