Skip to content

Commit

Permalink
Re-enable the yamllint truthy rule
Browse files Browse the repository at this point in the history
Previously we disabled the `truthy` rule due to Ansible's use of
`yes`/`no` for boolean values. That is no longer the case and the
default configuration used by ansible-lint now has this rule enabled.
The use of `on` as a key in GitHub Actions workflow syntax means we
needed to add disable-line comments for the truthy rule.
  • Loading branch information
mcdonnnj committed Dec 4, 2024
1 parent 66cdbf5 commit dd102fe
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: build

on:
on: # yamllint disable-line rule:truthy
merge_group:
types:
- checks_requested
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: sync-labels

on:
on: # yamllint disable-line rule:truthy
push:
paths:
- .github/labels.yml
Expand Down
4 changes: 0 additions & 4 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,3 @@ rules:
forbid-explicit-octal: true
# Do not allow implicit octal values (those beginning with a leading 0).
forbid-implicit-octal: true

# yamllint doesn't like when we use yes and no for true and false,
# but that's pretty standard in Ansible.
truthy: disable

0 comments on commit dd102fe

Please sign in to comment.